-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.2] [UX] Reset hidden postinstallation messages #37423
Conversation
The reset button should not be displayed (or it should be disabled) if there are no hidden messages. (I'm not convinced this button is a suitable solution to the issue. As I write in the issue there are several ways to achieve the aim. It all depends on what is the motivation/reason for the change. |
Thank you for your contribution, @magnussinger! This indeed solves the acute problem, that a hidden message cannot be reactivated. As you can see in the issue comments, this could be only an interim solution. |
Yes I'll fix that it only shows the button when messages are hidden later, but I think the solution with the button on top is a bit cleaner than minimizing hidden messages, but I'm open for suggestions |
@brianteeman I just updated my PR and it shows the button only when there are hidden messages now |
administrator/components/com_postinstall/src/Model/MessagesModel.php
Outdated
Show resolved
Hide resolved
@Quy I updated the button |
Please also fix the security token warning. Thanks. |
administrator/components/com_postinstall/src/View/Messages/HtmlView.php
Outdated
Show resolved
Hide resolved
@Quy I'm sorry but how can I see warnings in the backend? I somehow can't see the warning message |
Click the Reset button in the toolbar. |
administrator/components/com_postinstall/src/View/Messages/HtmlView.php
Outdated
Show resolved
Hide resolved
When I click on the reset button, there is no warning message, I just re-tried it |
Let me try again with the prebuilt package and report back later. |
Thanks |
Closing in favor of #38064. Thank you. |
Pull Request for Issue #37399
Summary of Changes
In the post-installation messages, you can now reset hidden messages before you have to hide all the other messages
Testing Instructions
There's an extra button in the toolbar, hide one message and press the reset button, and the message will be visible again
Actual result BEFORE applying this Pull Request
You had to hide all messages before making them visible again
Expected result AFTER applying this Pull Request
You can show hidden messages again before hiding all others before
Documentation Changes Required
None